Skip to content

Commit

Permalink
chore(cli): remove logs (#2014)
Browse files Browse the repository at this point in the history
This pull request includes several changes to the `cli/cmd/ui.go` file,
primarily focused on cleaning up unnecessary debug output and improving
the code's readability.

Code cleanup:

* Removed debug print statements that output the values of `legacyFlag`
and `clusterPort`, which were used for debugging purposes but are no
longer needed.

---------

Co-authored-by: alonkeyval <[email protected]>
  • Loading branch information
alonkeyval and alonbraymok authored Dec 16, 2024
1 parent 9c16b74 commit 1433f99
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions cli/cmd/ui.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ var uiCmd = &cobra.Command{
if legacyFlag {
clusterPort = legacyDefaultPort
}
fmt.Printf("Is legacy: %v\n", legacyFlag)
fmt.Printf("Cluster port: %d\n", clusterPort)

localAddress := cmd.Flag("address").Value.String()
uiPod, err := findOdigosUIPod(client, ctx, ns)
if err != nil {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ const renderValue = (type: DataCardRow['type'], value: DataCardRow['value']) =>
type={NOTIFICATION_TYPE.INFO}
message={
hasPresenceOfOtherAgent
? `By default, we do not operate alongside the ${otherAgent} Agent. Please contact the Odigos team for guidance on enabling this configuration.`
? `By default, we do not operate alongside the ${otherAgent}. Please contact the Odigos team for guidance on enabling this configuration.`
: canRunInParallel
? `We are operating alongside the ${otherAgent} Agent, which is not the recommended configuration. We suggest disabling the ${otherAgent} Agent for optimal performance.`
? `We are operating alongside the ${otherAgent}, which is not the recommended configuration. We suggest disabling the ${otherAgent} for optimal performance.`
: `Concurrent execution with the ${otherAgent} is not supported. Please disable one of the agents to enable proper instrumentation.`
}
/>
Expand Down

0 comments on commit 1433f99

Please sign in to comment.