1.20.6 update draft #246
1.20.6 update draft #246
Conversation
…ass to track lodestone
There was a problem hiding this comment.
Really really huge thanks @Sylfare for making this! This really is a monster sized update this time.
I'll test some things regarding the enchantments right now. I guess in the worst case we need to find a temporary workaround for 1.20.6 and then transition to datapacks as soon as 1.21 comes around (which I hope wont be too far out)
Is there anything else left to do?
| } else { | ||
| get_module().log.info("Serving official vane resource pack"); | ||
| try { | ||
| Properties properties = new Properties(); | ||
| properties.load(Core.class.getResourceAsStream("/vane-core.properties")); | ||
| url = properties.getProperty("resource_pack_url"); | ||
| sha1 = properties.getProperty("resource_pack_sha1"); | ||
| uuid = UUID.nameUUIDFromBytes(sha1.getBytes()); |
There was a problem hiding this comment.
If I understand this feature correctly, I think we should use a static uuid that we generate once. Then we can set replace(true) to make sure that a new resource pack with a different shasum will replace the old one
| @@ -99,8 +99,8 @@ public void load(CompoundTag nbt) {} | |||
| @Override | |||
| public void setItem(ItemStack itemStack) { | |||
| super.setItem(itemStack); | |||
|
|
|||
| if (itemStack.hasCustomHoverName()) { | |||
| // FIXME not sure | |||
There was a problem hiding this comment.
What are you not sure about? I guess you can easily test this by creating a portal and seeing whether the target is shown above the item
ItemParserto parse components instead of NBT