Repository navigation
pixel-peeper: rebuild the trial set on upright crops - #399
Merged
Merged
Conversation
#396 fixed load_source so a HIF is rotated before cropping, and ten of the eighteen trial sources are rotated HIFs, so most of the set had been cut out of a sideways frame. This is that fix reaching the page. 18 trials kept of 31 built: chroma 1, encoder 6, quality 8, tradeoff 3 16 of 18 carry the same axis and source as before; the crops moved 50 tiles, 901 KB worst equal-budget drift shipped: 1.84% 28 candidates dropped, each with its reason logged The drops are the generator working rather than a loss: most are chroma trials where 4:2:0 costs so little that no one could see the difference, and a trial nobody can call is not a test. Same rule that rejected the original set's unequal-byte encoder comparison. Manifest and tiles verified in bijection, 50 named and 50 on disk, none missing and none orphaned.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
aadhar-sh | a3d9751 | Aug 15 2026, 12:07 PM |
Contributor
Wire-size diff vs merge base
Brotli q11, the quality the edge serves. Every number here is deterministic: Client assetsNo change. 20 files, 73.98 KiB Brotli total. PagesNo change. 48 files, 496.95 KiB Brotli total. Worker bundleNo change. 271.96 KiB gzip. Dictionary deltas (
|
oddharsh
added a commit
that referenced
this pull request
Aug 16, 2026
…verse (#416) This gotcha claimed twice that the Copilot check fails on every diff, and one of those claims went in a few hours ago as the general lesson. It is wrong. The run always fires; whether it REQUESTS A MODEL depends on the diff. The job prints a file exclusion list on every run, covering js, json, mjs, ts, py, rs, yaml, yml, html, xml, go, java, c/cpp, rb and more. `.md`, `.sh` and `.css` are NOT on it. So a docs diff survives the filter and gets a `claude-opus-4.6` request, while a pure JavaScript diff is filtered to nothing and the run exits clean. Both paths print `Sessions disabled: not supported for code scanning yet`, which this session initially read as the discriminator and is not; the discriminating line is `Creating copilot-sdk session with model`, which only the failing path reaches. Correlates 12 of 12: the five runs of 2026-08-15 (#399 jpg/json and #402 js/mjs passed; #398, #400 and #401 all carried md and failed), plus all seven earlier failures checked backwards. #313 is the "CSS-only" diff this gotcha already singles out, and css is not on the list either. #351's note here called its entire diff a `${{ }}` move in workflow files; it touched md and mjs too, and the md is what drew the request. The prose-only argument is unchanged in conclusion and inverted in mechanism: a docs PR reddens this because markdown is one of the few things the detector still looks at, rather than because the agent choked on prose. The entitlement root cause is untouched. Records the method failure too, since it is the transferable part. Nine entries were built by pattern-matching outcomes across PRs without once reading which files each diff touched, and "fails on everything" was an artifact of that sample. One uncollected column explained the whole shape. Co-authored-by: Aadharsh Pannirselvam <19518661+oddharsh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#396 fixed load_source so a HIF is rotated before cropping, and ten of the
eighteen trial sources are rotated HIFs, so most of the set had been cut
out of a sideways frame. This is that fix reaching the page.
18 trials kept of 31 built: chroma 1, encoder 6, quality 8, tradeoff 3
16 of 18 carry the same axis and source as before; the crops moved
50 tiles, 901 KB
worst equal-budget drift shipped: 1.84%
28 candidates dropped, each with its reason logged
The drops are the generator working rather than a loss: most are chroma
trials where 4:2:0 costs so little that no one could see the difference,
and a trial nobody can call is not a test. Same rule that rejected the
original set's unequal-byte encoder comparison.
Manifest and tiles verified in bijection, 50 named and 50 on disk, none
missing and none orphaned.