-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try out standard indentation #57
Conversation
jgerigmeyer
commented
May 30, 2023
✅ Deploy Preview for sass-site-oddbird ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
View diff of compiled files (may take a few minutes): https://github.com/oddbird/sass-site-built/compare/main..indentation |
@jerivas @sanajaved7 I think this seems to work well, so that we can use more typical indentation for paired shortcodes (e.g. Note that it doesn't solve the problem of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Makes it way easier to browse a file and identify the blocks of content 👍
@jerivas I think I converted the remaining pages, so this is ready for final review ✔️ |
@@ -69,7 +69,7 @@ table_of_contents: true | |||
|
|||
{{ '## `@media`' | markdown }} | |||
|
|||
{% # Arguments are (in order): `dart`, `libsass`, `node`, `ruby`, optional feature name, additional details within %} | |||
{% # Arguments are (in order): `dart`, `libsass`, `node`, `ruby`, optional feature name, `useMarkdown` boolean, additional details within %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but what do you think about changing {% compatibility %}
to accept string arguments instead, and parse them in the TS implementation into a proper object:
{% compatibility 'dart:"1.11.0"', 'libsass:false', 'ruby:false', 'feature:"Range Syntax"', 'useMarkdown:false' %}
Advantages:
- We can get rid of the comment before each invocation
- No need to specify
null
for unused arguments, not including them should be enough - If 11ty lands support for kwargs, we can migrate to them with a regex that removes the single quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it! I'll try that out in this another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented in #59.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! so much easier to read