Release ocluster-worker and associated library as a standalone package
#217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterDA
force-pushed
the
ocluster-worker-standalone
branch
from
23e8d0b to
b334134
Compare
Member
tmcgilchrist
left a comment
tmcgilchrist
left a comment
There was a problem hiding this comment.
I think the library for ocluster-worker is the interesting part and would be in favour of releasing the tools to build a worker. I can’t see ocluster-worker executable being useful in general.
Comment on lines
+20
to
+21
| "capnp-rpc-lwt" | ||
| "cohttp-lwt-unix" |
Member
There was a problem hiding this comment.
These need lower bounds I think.
Contributor
Author
|
Thanks! |
MisterDA
added a commit
to MisterDA/opam-repository
that referenced
this pull request
Mar 2, 2023
…uster (0.2.1) CHANGES: - Expose the ocluster-worker library in the ocluster-worker package (@MisterDA @art-w, ocurrent/ocluster#219 ocurrent/ocluster#217 ocurrent/ocluster#151, reviewed by @tmcgilchrist) - Remove corrupted repositories from the cache (@kit-ty-kate ocurrent/ocluster#216, reviewed by @talex5) - Allow workers to report additional prometheus metrics (@patricoferris ocurrent/ocluster#210, reviewed by @tmcgilchrist, @MisterDA) - Smother Cap'n Proto and TLS debug logs (@MisterDA ocurrent/ocluster#213, reviewed by @talex5) - Added command line option to set obuilder health check period (@mtelvers ocurrent/ocluster#214, reviewed by @tmcgilchrist) - Conditionally compile macos user_temp fetcher (@tmcgilchrist ocurrent/ocluster#209, reviewed by @MisterDA, @mtelvers) - Make rsync-mode mandatory when using rsync store (@tmcgilchrist ocurrent/ocluster#202, reviewed by @MisterDA) - Windows service bugfixes (@MisterDA ocurrent/ocluster#200, reviewed by @tmcgilchrist) - Fix build and opam metadata (@MisterDA @tmcgilchrist ocurrent/ocluster#199 ocurrent/ocluster#203)
MisterDA
added a commit
to MisterDA/opam-repository
that referenced
this pull request
Mar 3, 2023
…uster (0.2.1) CHANGES: - Expose the ocluster-worker library in the ocluster-worker package (@MisterDA @art-w, ocurrent/ocluster#219 ocurrent/ocluster#217 ocurrent/ocluster#151, reviewed by @tmcgilchrist) - Remove corrupted repositories from the cache (@kit-ty-kate ocurrent/ocluster#216, reviewed by @talex5) - Allow workers to report additional prometheus metrics (@patricoferris ocurrent/ocluster#210, reviewed by @tmcgilchrist, @MisterDA) - Smother Cap'n Proto and TLS debug logs (@MisterDA ocurrent/ocluster#213, reviewed by @talex5) - Added command line option to set obuilder health check period (@mtelvers ocurrent/ocluster#214, reviewed by @tmcgilchrist) - Conditionally compile macos user_temp fetcher (@tmcgilchrist ocurrent/ocluster#209, reviewed by @MisterDA, @mtelvers) - Make rsync-mode mandatory when using rsync store (@tmcgilchrist ocurrent/ocluster#202, reviewed by @MisterDA) - Windows service bugfixes (@MisterDA ocurrent/ocluster#200, reviewed by @tmcgilchrist) - Fix build and opam metadata (@MisterDA @tmcgilchrist ocurrent/ocluster#199 ocurrent/ocluster#203)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts at replacing #151.
I'm introducing a new package,
ocluster-worker, which contains the publicocluster-workerbinary and publicocluster-workerlibrary (the previous PR only exposed the library in this package).The
ocluster-workerpackage will now depend on the correct released version of theobuilderpackage: in this mode,obuilderis not vendored as a submodule. If projects using theocluster-workerlibrary just depend on theocluster-workerpackage and link with the library, I think this solves your problem.The main issue we've been having with vendoring projects as submodules is when the same project gets vendored multiple times. Unless I'm wrong, that's not what's happening with your use case.
I'm not entirely convinced we need a new package either: we could just expose the
ocluster-workerlibrary as part of theoclusterpackage. It also seemed more logical to add theocluster-workerbinary to theocluster-workerpackage.I've also made the
oclusterpackage depend onocluster-workeras a kind of meta-package.cc @ElectreAAS @art-w
EDIT: we've confirmed offline the current-bench project just needs the
ocluster-workerlibrary exposed. Do we want to expose it as part of theoclusterpackage, or in a new package?