Make rsync-mode mandatory when using rsync store. #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Fixing comments from @kit-ty-kate on ocurrent/ocluster#189 |
Contributor
|
Isn't there a nicer way to let cmdliner know the options "couldn't be parsed" because it was required in this context? |
kit-ty-kate
approved these changes
Nov 16, 2022
MisterDA
requested changes
Nov 29, 2022
tmcgilchrist
force-pushed
the
rsync_mode
branch
2 times, most recently
from
7dde7da to
9c101e4
Compare
tmcgilchrist
force-pushed
the
rsync_mode
branch
from
9c101e4 to
b6d6bb3
Compare
kit-ty-kate
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Feb 20, 2023
CHANGES: - Updates to address rsync and sandbox issues. (@mtelvers ocurrent/obuilder#139, reviewed by @tmcgilchrist and @MisterDA) - Add an obuilder clean command to clean all build results. (@MisterDA ocurrent/obuilder#140, reviewed by @tmcgilchrist) - Make rsync-mode mandatory when using rsync store. (@tmcgilchrist ocurrent/obuilder#132, reviewed by @kit-ty-kate and @MisterDA)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocluster worker changes ocurrent/ocluster#202
On master before this change the stress tests for rsync were running using copy, this change enables tests for both copy and hardlink. Running the hardcopy_unsafe resulted in consistent failures so they are disabled.