Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review Commit (please review) #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Code Review Commit (please review) #1

wants to merge 1 commit into from

Conversation

octosliu
Copy link
Collaborator

@octosliu octosliu commented Sep 5, 2024

Directions

For this exercise, please review the following methods in the s3_utils.py and test_s3_utils.py files:
_get_byte_offsets_and_parts
_large_copy_object_to_aws
_upload_part_to_aws

This code was intentionally designed for interview purposes -- so fear not, you won't offend anyone!

Criteria:

  • These methods are part of a multicloud solution intended to decrease costs of transferring assets across regions.
  • Please do not spend time independently validating or invalidating the math for any of the methods, as that’s beyond the intent of this exercise.
  • Please review the methods and included tests. We are looking for technical communication that happens asynchronously, thinking through technical problems, and clarification where information is not complete.

Setup Directions

It's recommended you use a virtual environment such as venv or conda.
You can run pip install poetry or install the packages in the pyproject.toml file.
If using poetry, you can install all packages by running the following from the root directory:
poetry install

Running tests

You can run tests using the following command from the root directory:
pytest test_s3_utils.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant