Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Remove the confusion about the application of Chat Template #187

Open
sunggg opened this issue Feb 1, 2024 · 0 comments
Open

[Feature Request] Remove the confusion about the application of Chat Template #187

sunggg opened this issue Feb 1, 2024 · 0 comments

Comments

@sunggg
Copy link
Member

sunggg commented Feb 1, 2024

Currently, mlc-serve takes prompts in two paths: request.mesasges and request.debug_options.prompt.
https://github.com/octoml/mlc-llm/blob/batch-serving/serve/mlc_serve/engine/engine_common.py#L43

The expected behavior is not clear until you deep-dive the codebase.
Better way can be have a flag to disable the application of chat template.
Lunderberg pushed a commit to Lunderberg/mlc-llm that referenced this issue Feb 27, 2024
@tqchen @cyx-6
Add model weight variant in iOS (octoml#187)
da63f2c 
Co-authored-by: Yaxing Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sunggg