Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): use .js extension instead of .ts #949

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

wolfy1339
Copy link
Member

Resolves octokit/octokit.js#2597


Before the change?

  • Used a .ts path in production code

After the change?

  • Uses .js path in production code

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented, or is being fixed label Dec 20, 2023
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@bttf
Copy link

bttf commented Jan 5, 2024

Could use this fix - currently having to use patch-package to avoid this issue for our app

@wolfy1339 wolfy1339 enabled auto-merge (squash) January 5, 2024 20:52
@wolfy1339 wolfy1339 merged commit a00257a into main Jan 5, 2024
6 checks passed
@wolfy1339 wolfy1339 deleted the remove-ts-extension-src branch January 5, 2024 20:53
Copy link
Contributor

github-actions bot commented Jan 5, 2024

🎉 This PR is included in version 12.0.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented, or is being fixed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: An import path cannot end with a '.ts' extension
3 participants