Skip to content

maint: Added base64 gem explicitly dependency #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2024
Merged

maint: Added base64 gem explicitly dependency #1658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions octokit.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
require 'octokit/version'

Gem::Specification.new do |spec|
spec.add_dependency 'base64'
Copy link
Contributor

@nickfloyd nickfloyd Jan 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
spec.add_dependency 'base64'
spec.add_dependency 'base64' if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.3')

What are thoughts about approaching it like this? I know that it shouldn't matter but I would like to reduce the surface area of the impact. Given that pre v3.3 can getbase64 from stdlib without the warn I think this approach should be ok.

Let me know your thoughts when you get the chance, I am good with either way! Thanks.

Copy link
Contributor Author

@hsbt hsbt Jan 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfotunately, it's not working. I'm member of Ruby core team and RubyGems team.

RubyGems couldn't handle condition of Ruby version for dependency. RubyGems only support required_ruby_version and required_rubygems_version for gemspec, not dependency.

Copy link
Contributor

@nickfloyd nickfloyd Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarity! I've merged it as is and will ship it once I get a few more changesets in.

spec.add_dependency 'faraday', '>= 1', '< 3'
spec.add_dependency 'sawyer', '~> 0.9'
spec.authors = ['Wynn Netherland', 'Erik Michaels-Ober', 'Clint Shryock']
Expand Down