Skip to content

Conversation

@MatisseHack
Copy link
Contributor

Resolves #2964


Before the change?

  • Runner group access APIs would return empty objects because they weren't wrapped in a response object

After the change?

  • Runner group access APIs return properly deserialized responses

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

I didn't see existing tests for deserialization, but I'm happy to add tests if there is an established pattern to follow.

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

The return type of several functions changed (although these functions would have returned empty objects before)


Copy link
Contributor

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: Runner group access APIs return empty objects

2 participants