BREAKING CHANGE: Issue ID should be a long #2962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the documentation at https://docs.github.com/en/rest/issues/issues. Fixes octokit#2351 for issue ids.
Contributor
|
This was already done in #2890. You've changed issue number, which is the "2351" in the linked issue |
Contributor
Author
|
vs
either one or the other is the wrong type. |
nickfloyd
added
Type: Breaking change
nickfloyd
changed the title
nickfloyd
approved these changes
Jan 8, 2025
Contributor
|
Merging this in as a preventative measure since this is a manually generated SDK. These changes, while breaking should have a nominal impact on usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation at https://docs.github.com/en/rest/issues/issues.
Fixes #2351 for issue ids.
Does this introduce a breaking change?
Please see our docs on breaking changes to help!