Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING CHANGE]: Removes the .NET 5.0 support #2806

Merged
merged 2 commits into from
Oct 31, 2023
Merged

[BREAKING CHANGE]: Removes the .NET 5.0 support #2806

merged 2 commits into from
Oct 31, 2023

Conversation

nickfloyd
Copy link
Contributor

@nickfloyd nickfloyd commented Oct 31, 2023 •
edited
Loading

The .NET 5.0 SDK has been EoL since May 2022 and should no longer be needed (unless mono requires it), so our tooling here needs to reflect that.

Before the change

  • .net 5.0 SDK is installed when the container gets instantiated using the dev container file
  • Supported versions: net5.0, net5.0-windows, net6.0, net6.0-android, net6.0-ios, net6.0-maccatalys, net6.0-macos , net6.0-tvos, net6.0-windows , net7.0 , net7.0-android , net7.0-ios net7.0-ios , net7.0-maccatalyst , net7.0-macos , net7.0-tvos net7.0-tvos , net7.0-windows

After the change

  • .net 6.0 SDK is the only version installed when the container gets instantiated using the dev container file
  • Supported versions: net6.0, net6.0-android, net6.0-ios, net6.0-maccatalys, net6.0-macos , net6.0-tvos, net6.0-windows , net7.0 , net7.0-android , net7.0-ios net7.0-ios , net7.0-maccatalyst , net7.0-macos , net7.0-tvos net7.0-tvos , net7.0-windows

relates to: #2616

@nickfloyd nickfloyd changed the title [draft] removes the SDK from the container directive. [draft] removes the .NET 5.0 SDK from the container directive. Oct 31, 2023
@nickfloyd nickfloyd self-assigned this Oct 31, 2023
@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR hacktoberfest Issues for participation in Hacktoberfest labels Oct 31, 2023
@nickfloyd nickfloyd marked this pull request as ready for review October 31, 2023 18:26
@nickfloyd nickfloyd changed the title [draft] removes the .NET 5.0 SDK from the container directive. Removes the .NET 5.0 from the SDK Oct 31, 2023
@nickfloyd nickfloyd changed the title Removes the .NET 5.0 from the SDK Removes the .NET 5.0 support Oct 31, 2023
@nickfloyd nickfloyd added the Type: Breaking change Used to note any change that requires a major version bump label Oct 31, 2023
@nickfloyd nickfloyd changed the title Removes the .NET 5.0 support [BREAKING CHANGE]: Removes the .NET 5.0 support Oct 31, 2023
@nickfloyd nickfloyd merged commit 27aa6e5 into main Oct 31, 2023
5 checks passed
@nickfloyd nickfloyd deleted the remove-dotnet5.0-sdk branch October 31, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

@JamieMagee JamieMagee JamieMagee approved these changes

Assignees

@nickfloyd nickfloyd

Labels
hacktoberfest Issues for participation in Hacktoberfest Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickfloyd @JamieMagee @kfcampbell