Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Expose WebCommitSignoffRequired and HasDiscussions for get and update repository objects #2773

Merged
merged 4 commits into from
Sep 22, 2023
Merged

[feat] Expose WebCommitSignoffRequired and HasDiscussions for get and update repository objects #2773

merged 4 commits into from
Sep 22, 2023

Conversation

SlyckLizzie
Copy link
Contributor

@SlyckLizzie SlyckLizzie commented Sep 17, 2023 •
edited
Loading

Resolves #2772

Before the change?

  • The WebCommitSignoffRequired and HasDiscussions fields exposed by the REST API are not implemented by octokit.net

After the change?

  • The WebCommitSignoffRequired and HasDiscussions fields will be implemented by octokit.net for the get and update repository objects

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@SlyckLizzie SlyckLizzie changed the title expose WebCommitSignoffRequired for get and update repository objects Expose WebCommitSignoffRequired and HasDiscussions for get and update repository objects Sep 22, 2023
@nickfloyd nickfloyd added the Type: Feature New feature or request label Sep 22, 2023
nickfloyd
nickfloyd approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the commits @dirtygooback ❤️

@nickfloyd nickfloyd changed the title Expose WebCommitSignoffRequired and HasDiscussions for get and update repository objects [feat] Expose WebCommitSignoffRequired and HasDiscussions for get and update repository objects Sep 22, 2023
@nickfloyd nickfloyd merged commit 50265be into octokit:main Sep 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

Assignees
No one assigned
Labels
Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add WebCommitSignoffRequired to the Repository get/update objects
2 participants
@SlyckLizzie @nickfloyd