Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing empty object paramater in MigrationsClient.DeleteArchive #2698

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Removing empty object paramater in MigrationsClient.DeleteArchive #2698

merged 3 commits into from
Apr 14, 2023

Conversation

gitasaurus
Copy link
Contributor

@gitasaurus gitasaurus commented Apr 13, 2023

Resolves #2697


Behavior

Before the change?

  • MigrationsClient.DeleteArchive throws an ArgumentException - The value cannot be null or empty. (Parameter 'mediaType') when invoked in an application compiled using .Net 7.0

After the change?

  • MigrationsClient.DeleteArchive succeeds on .Net 7.0.

Other information

  • Requires modifying Octokit.Tests/Clients/MigrationsClientTests.cs (any object was required by the test, hence the new object() parameter being added to pass the test)

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kfcampbell kfcampbell merged commit a3299ac into octokit:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: .NET 7.0 causes ArgumentException in Migrations.DeleteArchive
2 participants