Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the old implementation of sourcelink and uses the newer one present in the .net SDK #2666

Merged
merged 5 commits into from
Feb 7, 2023

Conversation

nickfloyd
Copy link
Contributor

@nickfloyd nickfloyd commented Feb 6, 2023

We discovered that we were using the old implementation of source link as well as using the new implementation in the csproj files.

The old source link test is causing CI to break (due to a dev cert issue). Instead of using the hammer of dotnet dev-certs clean and trust, we will just remove the old references.

Relates to:
#2648
#2665


Behavior

Before the change?

  • CI is currently broken and the sourcelink step is no longer linking symbols for debugging

After the change?

  • CI works and symbols are source linked for local debugging

Other information

  • Symbols and debugging will need to be validated in the produced and published nuget package

Related info:


Additional info

Pull request checklist

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

@nickfloyd nickfloyd added Priority: High Type: Bug Something isn't working as documented Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR dependencies Pull requests that update a dependency file labels Feb 6, 2023
@nickfloyd nickfloyd marked this pull request as draft February 6, 2023 21:20
@nickfloyd nickfloyd requested a review from kfcampbell February 6, 2023 21:20
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!

docs/debugging-source.md Outdated Show resolved Hide resolved
@nickfloyd
Copy link
Contributor Author

Screenshot 2023-02-06 at 11 33 59 PM

Co-authored-by: Keegan Campbell <[email protected]>
@nickfloyd nickfloyd marked this pull request as ready for review February 7, 2023 05:35
@nickfloyd nickfloyd merged commit 00b89da into main Feb 7, 2023
@nickfloyd nickfloyd deleted the replace-sourcelink branch February 7, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Type: Bug Something isn't working as documented Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants