upgrade project tooling to .NET Core 3.1 #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
shiftkey
commented
Feb 9, 2020
•
shiftkey
commented
- Appveyor passes
- Actions passes
- tidy up about global tools
- review diff
shiftkey
force-pushed
the
bump-everything-to-netcore3
branch
from
a63724a to
33835ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #2089 +/- ##
=======================================
Coverage 67.06% 67.06%
=======================================
Files 538 538
Lines 14138 14138
=======================================
Hits 9481 9481
Misses 4657 4657 |
shiftkey
force-pushed
the
bump-everything-to-netcore3
branch
2 times, most recently
from
f15c63c to
75cb523
Compare
|
release_notes: upgraded project tooling to .NET Core 3.1 |
jetersen
reviewed
Feb 10, 2020
| <Project> | ||
| <PropertyGroup> | ||
| <EmbedUntrackedSources>true</EmbedUntrackedSources> | ||
| <TargetFrameworkMonikerAssemblyAttributesPath>$([System.IO.Path]::Combine('$(IntermediateOutputPath)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)'))</TargetFrameworkMonikerAssemblyAttributesPath> |
There was a problem hiding this comment.
Instead of this, you can use https://www.nuget.org/packages/Microsoft.NETFramework.ReferenceAssemblies/
for compiling with mono.
https://stu.dev/dotnet-framework-reference-assemblies-via-nuget/
There was a problem hiding this comment.
I'm already using Microsoft.NETFramework.ReferenceAssemblies in this project, and this workaround was due to an upgrade issue that I uncovered related to .NET Core 3.1 and Sourcelink.
The details are over here, if you wanted to follow along: shiftkey/dotnetcore-sourcelink-test-bug#1
nickfloyd
added
Type: Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.