Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ID property to Milestone #2007

Merged
merged 2 commits into from
Sep 21, 2019
Merged

Add missing ID property to Milestone #2007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30bd374
Add Id property to Milestone model
hnrkndrssn Sep 21, 2019
b5e406d
Exclude Riders workspace directory
hnrkndrssn Sep 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,7 @@ Backup/
tools/*
!tools/gitversion_wrapper.sh
!tools/LINQPad
coverage-results/*
coverage-results/*

# Rider
**/.idea/*
8 changes: 7 additions & 1 deletion Octokit/Models/Response/Milestone.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ public Milestone(int number)
Number = number;
}

public Milestone(string url, string htmlUrl, int number, string nodeId, ItemState state, string title, string description, User creator, int openIssues, int closedIssues, DateTimeOffset createdAt, DateTimeOffset? dueOn, DateTimeOffset? closedAt, DateTimeOffset? updatedAt)
public Milestone(string url, string htmlUrl, long id, int number, string nodeId, ItemState state, string title, string description, User creator, int openIssues, int closedIssues, DateTimeOffset createdAt, DateTimeOffset? dueOn, DateTimeOffset? closedAt, DateTimeOffset? updatedAt)
{
Url = url;
HtmlUrl = htmlUrl;
Id = id;
Number = number;
NodeId = nodeId;
State = state;
Expand All @@ -41,6 +42,11 @@ public Milestone(string url, string htmlUrl, int number, string nodeId, ItemStat
/// The Html page for this milestone.
/// </summary>
public string HtmlUrl { get; protected set; }

/// <summary>
/// The ID for this milestone.
/// </summary>
public long Id { get; protected set; }

/// <summary>
/// The milestone number.
Expand Down