v0.21.1 - I've Made A Huge Mistake #1434
Conversation
|
Oh dear! I saw it mentioned 0.21 was shipping tomorrow so I didn't review it earlier (that was a task for tonight) :grinning I'll check these amendments out soon |
|
|
||
| **Features** | ||
|
|
||
| Due to an programming error in the tool to generate these release notes, additional |
There was a problem hiding this comment.
an programming => a programming
|
I've run my own "PR's merged between 2 refs" code against this release and found another couple of PRs that aren't currently in the list: PR#1398 Updated git data commit response with signature verification object via @Sarmad93 PR#1402 Fix serialization of enum value attributes via @maddin2016 PR#1341 Include reactions on issue comments via @alfhenrik |
| Due to an programming error in the tool to generate these release notes, additional | ||
| features were not properly documented for the previous release: | ||
|
|
||
| - Reactions preview API support for issues, commit comments and PR comments - #1335, #1405 via @maddin2016 |
There was a problem hiding this comment.
There are actually 4 (not 3) items that Reactions are supported for: commit comments, issues, issue comments, pull request review comments
|
@ryangribble thanks for the sanity check. I called out #1402 in the previous release, and I'll add the others here. |
|
I was confused when you said "previous release" (I thought you mean v0.20) so all good. My query was from v0.20.0...master so 1402 coming up is correct, I just failed when seeing what you'd already listed in the release notes 😀 |
shiftkey
force-pushed
the
now-with-added-release-notes
branch
from
0223b7a to
eeca298
Compare
|
This is shipped (again) |
I published up v0.21 today without realising I missed calling out some of the new work that @maddin2016 had contributed. This is the remedy for that (yes, it's not technically a bugfix release but it'll help me sleep at night).