Signature Verification with commits. #1401
Conversation
|
@shiftkey I've added the Verification object inside Commit and not directly under GitHubCommit according to the API. Also, I don't know whether we should create a class for the |
devkhan
force-pushed
the
sign-verification
branch
3 times, most recently
from
507b618 to
f93f517
Compare
| @@ -771,7 +771,7 @@ public void GetsCorrectUrl() | |||
| client.Get("owner", "name", "reference"); | |||
|
|
|||
| connection.Received() | |||
| .Get<GitHubCommit>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/name/commits/reference")); | |||
| .Get<GitHubCommit>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/name/commits/reference"), null, AcceptHeaders.SignatureVerificationPreview); | |||
There was a problem hiding this comment.
looks like a tab/whitespace issue here (and in other places)
There was a problem hiding this comment.
Also, we don't want to use implementation logic as part of the test, so rather than using the AcceptHeaders helper, can you hardcode the expected header in the tests?
|
@devkhan looks like you need to adjust your tab settings as most files are showing whitespace/alignment issues |
|
Also, @Sarmad93 has a PR at #1398 that is aiming to add this verification info to the |
|
@ryangribble Yeah, I recently started using Xamarin, so didn't noticed the tabs/spaces. Will fix it after #1398 is merged. Thanks. |
|
#1398 has been merged |
devkhan
force-pushed
the
sign-verification
branch
from
f93f517 to
af30260
Compare
|
Still got merge conflicts on this one, also dont forget about the tab/space issues 😀 |
Resolves #1255.
A
Verificationobject insideGitHubCommit.Commit.To-do: