Add repositoryId overloads to methods on I(Observable)EventsClient #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified XML docs
|
@ryangribble please rerun Travis whenever possible 👍 |
|
I've cleared tags here. |
|
This one is good, apart from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of my work on #1120 I've added new overloads on I(Observable)EventsClient to get access by repository id.
Update XML documentation of interface methods of clients (also synchronize XML docs of IEventsClient and IObservableEventsClient).
There is some divergence between XML documentation of methods in IEventsClient and IObservableEventsClient. So I've decided
to sync XML documentation of these classes during my work on Add support for interacting with repositories by id. #1120.
Add overloads to IEventsClient.
Just add overloads of existing methods that use repositoryId to work with repo.
Add overloads to IObservableEventsClient.
Just add overloads of existing methods that use repositoryId to work with repo.
Add unit tests.
I've added new unit tests that use repositoryId to work with repo that is just a full copy of existing tests that use (owner, name) key.
Also I've found out that not all methods are covered by tests and added them for new and for old methods.
Add integration tests.
I've added new integration tests that use repositoryId to work with repo that is just a full copy of existing tests that use (owner, name) key.
Also I've found bug in deserialization, see Deserialization error on Activity type #1374 for details. I skipped failed new integration tests because of this.
/cc @shiftkey, @ryangribble