Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: /user/repos search cannot mix type and visibility/affiliation #1107

Closed
shiftkey opened this issue Feb 14, 2016 · 2 comments
Closed
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@shiftkey
Copy link
Member

There's two integration tests which are failing currently after merging #1096:

  • RepositoriesClientTests+TheGetAllForCurrentMethod.CanChangeSortDirection
  • RepositoriesClientTests+TheGetAllForCurrentMethod.CanSortResults

These both return an error:

HTTP/1.1 422 Unprocessable Entity
[other headers here]

{"message":"If you specify visibility or affiliation, you cannot specify type.","documentation_url":"https://developer.github.com/v3/repos/#list-your-repositories"}

And if you look at the URLs that we send:

GET https://api.github.com/user/repos?type=all&sort=created&direction=asc&visibility=public&affiliation=owner HTTP/1.1
[other headers here]

We just need to be smarter with the defaults so that they're not overlapping.

@AlexP11223
Copy link
Contributor

What do you mean by "be smarter with the defaults"?
Do we need to add something like Default/NotSpecified (with null value) as a default value to Visibility and Affiliation enums?

AlexP11223 added a commit to AlexP11223/octokit.net that referenced this issue Mar 7, 2016
AlexP11223 added a commit to AlexP11223/octokit.net that referenced this issue Mar 8, 2016
shiftkey added a commit that referenced this issue Mar 10, 2016
…lation-mix-1107

#1107 Do no set default visibility and affiliation values to avoid mixing with type
@shiftkey
Copy link
Member Author

Fixed in #1132

@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

3 participants