Defer openpyxl import #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joetsoi
force-pushed
the
defer-openpyxl-import
branch
2 times, most recently
from
febc346 to
198e2dd
Compare
cgl
reviewed
Apr 14, 2023
pytest.ini
Outdated
There was a problem hiding this comment.
❓Should this be addressed/discussed in a separate PR?
There was a problem hiding this comment.
Happy to split it off into its own pr if it's clearer/easier to discuss, but I figured this was a small enough pr and I wanted to get the main branch fixed quickly. I briefly looked into the yak shave of making the pytz->zoneinfo change, but it's a bit larger than I wanted to bite off for now
joetsoi
force-pushed
the
defer-openpyxl-import
branch
2 times, most recently
from
f0021d1 to
fbbed26
Compare
cgl
approved these changes
Apr 17, 2023
pytest.ini
Outdated
See https://adamj.eu/tech/2023/03/02/django-profile-and-improve-import-time/#defer-imports openpyxl takes ~0.2 seconds to import. This is included in every pytest run whether convert_xlsx_to_csv is used or not.
joetsoi
force-pushed
the
defer-openpyxl-import
branch
from
fbbed26 to
f8cfcbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy win stolen wholesale from this Wednesday's django london talk
See https://adamj.eu/tech/2023/03/02/django-profile-and-improve-import-time/#defer-imports
openpyxl takes ~0.2 seconds to import. This is included in every pytest run whether convert_xlsx_to_csv is used or not.
This also fixes the main branch which is broken since the release of django 4.2 by silencing the pytz usage issues. Maybe another spaday task!