Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ddtrace dependency #56

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Move ddtrace dependency #56

merged 3 commits into from
Mar 24, 2023

Conversation

cgl
Copy link
Collaborator

@cgl cgl commented Mar 23, 2023

Prior to this change, ddtrace was in development dependencies, but it is a core dependency for the tracing module.

This change moves ddtrace from dev dependencies to core dependencies.

@cgl cgl requested review from noelia-mari and a team March 23, 2023 09:44
Copy link
Contributor

@noelia-mari noelia-mari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 😄 I have a question, should we update the CHANGELOG and bump the version in this same PR? 🤔

cgl added 2 commits March 24, 2023 13:26
Prior to this change, ddtrace was in development dependencies,
but it is a core dependency for the tracing module.

This change moves ddtrace from dev dependencies to core dependencies.
@cgl cgl force-pushed the cgl/fix-ddtrace-dependency branch from ee5223a to d197779 Compare March 24, 2023 13:36
@cgl cgl merged commit 88560d3 into main Mar 24, 2023
@cgl cgl deleted the cgl/fix-ddtrace-dependency branch March 24, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants