Add numpy dependency #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the numpy dependency used by pandas (imported in storage/files.py).
noelia-mari
requested review from
pydanny and
cgl
and removed request for
pydanny
pydanny
suggested changes
Mar 13, 2023
There was a problem hiding this comment.
Thanks for the PR! 🙂
I'm not certain this is necessary and a pinned numpy version might cause conflict downstream. Reading this from my phone, Pandas has numpy defined as a dependency across a range of versions.
Of course I might be wrong or you might be looking at something I'm not seeing.
pydanny
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
LGTM after talking to @noelia-mari, pandas isn't installing numpy by default.
Separately, I'll raise an issue about having xocto dependencies being a range rather than pinned dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
storage/files.pyis importing pandas and it needs the numpy dependency xocto should have it as an extra required dependency.