Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing to xocto #46

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Add tracing to xocto #46

merged 2 commits into from
Mar 6, 2023

Conversation

noelia-mari
Copy link
Contributor

@noelia-mari noelia-mari commented Mar 3, 2023

Add tracing file which is used to add more trace information to DataDog events.


@noelia-mari noelia-mari changed the base branch from main to bump-version-3.0.0 March 3, 2023 12:57
@noelia-mari noelia-mari requested review from jbkkd and cgl March 3, 2023 12:57
Base automatically changed from bump-version-3.0.0 to main March 3, 2023 13:15
xocto/tracing.py Outdated

def set_tags(tags: dict[str | bytes, str]) -> None:
"""
Sets multiple tags on the current span
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Sets multiple tags on the current span
Set multiple tags on the current span.

xocto/tracing.py Outdated

def set_tag(key: str, value: object) -> None:
"""
Sets a tag on the current span
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Sets a tag on the current span
Set a tag on the current span.

xocto/tracing.py Outdated
Comment on lines 29 to 30
Sets a tag on the current root span. These tags will be associated to the
entire Datadog Trace
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Sets a tag on the current root span. These tags will be associated to the
entire Datadog Trace
Set a tag on the current root span.
These tags will be associated to the entire Datadog trace.

This commit introduces the ddtrace dependency which tracing file needs.
This commit introduces the tracing file, which is used to add trace information in DataDog events.
@noelia-mari noelia-mari merged commit 95fbbf9 into main Mar 6, 2023
@noelia-mari noelia-mari deleted the add-tracing branch March 6, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants