Add localtime function period_exceeds_one_year #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peter554
force-pushed
the
localtime/add-period-exceeds-one-year
branch
2 times, most recently
from
7fe37ce to
2f69da1
Compare
pydanny
approved these changes
Feb 27, 2023
Useful for determining whether two datetimes are more than one year apart. Takes into account leap year and DST issues. Context: In germany an invoice may not legally cover more than one year of consumption
Peter554
force-pushed
the
localtime/add-period-exceeds-one-year
branch
from
2f69da1 to
b26f4cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for determining whether two datetimes are more than one year apart. Takes into account leap year and DST issues.
Context: In germany an invoice may not legally cover more than one year of consumption. This functionality is needed in a couple of places within germany logic, and can likely be useful for others too. Motivated by https://github.com/octoenergy/kraken-core/pull/72807 and https://github.com/octoenergy/kraken-core/pull/78884.