Update type annotation in get_finite_datetime_ranges_from_timestamps #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the
finite_datetime_range
argument to this function had the typeFiniteDatetimeRange
.The function doesn't use any of the methods from that class and works when called on objects of its parent type
FiniteRange[datetime.datetime]
, so this change updates the type annotation to reflect that.This caused an issue for me when iterating through a FiniteRangeSet and calling this function - the following works, but mypy currently doesn't allow it:
Gives this error: