Fix bug in FiniteDateRange.is_disjoint #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-lynch
force-pushed
the
ranges/bugfix-edge-of-time-handling
branch
from
40f0dd3 to
844eb65
Compare
greg-charvet-kraken
approved these changes
Oct 31, 2023
josh-lynch
force-pushed
the
ranges/bugfix-edge-of-time-handling
branch
2 times, most recently
from
c33c82d to
2003154
Compare
Closed
Previously if you called is_disjoint on a range containing either date.min or date.max you would get an OverflowError.
josh-lynch
force-pushed
the
ranges/bugfix-edge-of-time-handling
branch
from
2003154 to
3bec7eb
Compare
pydanny
previously requested changes
Nov 1, 2023
| @@ -1,5 +1,11 @@ | |||
| # Changelog | |||
|
|
|||
| ## v4.7.1 - 2023-11-01 | |||
|
|
|||
| - Adding explicit type for Optional OneToOneField [#113](https://github.com/octoenergy/xocto/pull/113) | |||
There was a problem hiding this comment.
In semver, this is a 4.8.0 change, not 4.7.1
setup.py
Outdated
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| REPO_ROOT = path.abspath(path.dirname(__file__)) | |||
|
|
|||
| VERSION = "4.7.0" | |||
| VERSION = "4.7.1" | |||
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
xocto/__init__.py
Outdated
| @@ -1 +1 @@ | |||
| __version__ = "4.7.0" | |||
| __version__ = "4.7.1" | |||
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| @@ -811,11 +811,17 @@ def is_disjoint(self, other: Range[datetime.date]) -> bool: | |||
| other_start = other.start | |||
| if other._is_left_inclusive: | |||
| assert other_start is not None | |||
| other_start -= datetime.timedelta(days=1) | |||
| try: | |||
| other_start -= datetime.timedelta(days=1) | |||
There was a problem hiding this comment.
Nothing needs to be changed here, merely a comment that I rarely see -=. 🤷🏻
josh-lynch
force-pushed
the
ranges/bugfix-edge-of-time-handling
branch
from
3bec7eb to
19ea90e
Compare
greg-charvet-kraken
approved these changes
Nov 1, 2023
prestto
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you called is_disjoint on a range containing either
date.min or date.max you would get an OverflowError.