Bugfix FiniteDateRange intersection #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-lynch
force-pushed
the
ranges/bugfix-intersection
branch
from
7e573a7 to
b1d7e69
Compare
delfick
reviewed
Oct 23, 2023
| try: | ||
| base_intersection = super().intersection(other) | ||
| except ValueError: | ||
| # This occurs when calling intersection on an adjacent date range. |
There was a problem hiding this comment.
is there a way to confirm that's the reason for the ValueError?
There was a problem hiding this comment.
I don't believe there is any other way we could get a ValueError coming up here, but I don't think there's any way programatically to specifically confirm that. Did you have something in mind?
I could replace raising a ValueError with a custom exception type, but it is a larger change.
The recent change to allow adjacent FiniteDateRanges to union (by changing the behaviour of is_disjoint) broke the behaviour of intersection for adjacent ranges, causing attempts to intersect adjacent ranges to raise ValueError instead of returning None. This change makes intersect on adjacent FiniteDateRanges return None again.
josh-lynch
force-pushed
the
ranges/bugfix-intersection
branch
from
b1d7e69 to
ada427c
Compare
delfick
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change to allow adjacent FiniteDateRanges to union (by
changing the behaviour of is_disjoint) broke the behaviour of
intersection for adjacent ranges, causing attempts to intersect
adjacent ranges to raise ValueError instead of returning None.
This change makes intersect on adjacent FiniteDateRanges return
None again.