Changed mouseScroll to use X and Y as direction. #194
Conversation
|
This is awesome, thanks for the PR! I'll have to think a bit about this. I like using "up" and "down", we do it in a few other places as well. Would it be possible to use "left" and "right"? |
|
I just don't see the need for using "up" or "down". It seems odd to use both a number and a direction instead of using something like a vector. We could add "left" and "right", but I am in the need of doing diagonal scrolling as well. I think using numbers would also make smooth scroll implementation easier. |
|
You're right that using just the numbers makes more sense. I'm fine with this, and breaking backwards compatibility is fine. Give me a bit to test this and I'll get it merged! Thanks again! |
| } | ||
|
|
||
| int xi; | ||
| int yi; |
There was a problem hiding this comment.
Would you mind fixing the whitespace here?
# Conflicts: # src/robotjs.cc
|
Did I do it correctly? Not sure what you mean... |
| int x; | ||
| int dir = 4; /* Button 4 is up, 5 is down. */ | ||
| Display *display = XGetMainDisplay(); | ||
| CFRelease(event); |
There was a problem hiding this comment.
Sorry I meant that there are a few places where spaces are used instead of tabs. If you select the characters before CFRelease release you'll see what I mean. I can fix them after this gets merged though, if you'd like!
|
I'd really like to get this function. Is it merged now? |
# Conflicts: # src/robotjs.cc
|
I just fixed the merge problem. Not sure what formating I need to fix. Could you link me to the style guide or the specific line number you have a problem with? |
|
Think I fixed all the spacing. |
|
How do I go about making sure that both parameters are numbers and then printing an error if they are not for the new scroll method? |
|
Is the repo dead? |
|
Hi @BHamrick1, it's not dead, I'm just busy. I'll try to take a look this week. Thanks! |
|
@BHamrick1 thanks for the PR. I was also thinking of extending robotjs for horizontal scrolling too but I tried this and it works. |
|
Do I need to change the documentation? |
|
Made the change in the docs octalmage/robotjs.io#3 |
|
@octalmage just to check when will this change be pushed to npm? |
|
0.4.6 has been released to npm! Thanks again! |
|
Why was the type script file not updated? https://github.com/octalmage/robotjs/blob/master/index.d.ts#L26 |
octalmage#194 never updated type script file
octalmage#194 never updated type script file
For my project I require side to side scrolling and have found that robotjs does not have any way of doing this. This change will make it so that you can specify a x and y coordinate like a vector for scrolling. Also instead of using 'up' and 'down' we would use negative and positive values.
I know that this removes how we previously did things so I am not sure if this needs to be a separate method or if we need to mark something as deprecated. I did it this way because robotjs is still relatively in alpha or pre.