Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding insert key. Fixes #184 #185

Merged
merged 4 commits into from
May 1, 2016
Merged

Adding insert key. Fixes #184 #185

merged 4 commits into from
May 1, 2016

Conversation

chaosprinz
Copy link
Contributor

Built and tested it under windows10. Cant test it on Mac/Linux

@chaosprinz
Copy link
Contributor Author

Ok, see it. Got Problems under linux. Will fix it soon.

@chaosprinz chaosprinz closed this Apr 29, 2016
@octalmage
Copy link
Owner

I can help with the Mac and Linux side of things! Lets leave this open and just blocked!

@chaosprinz
Copy link
Contributor Author

I think the last commit should fix it

@chaosprinz
Copy link
Contributor Author

Looks fine, so far. 👍

@Deltatiger
Copy link
Collaborator

@chaosprinz Could you please clean up the problem with removing tab spaces by your editor. It seems to have caused lot of changes.
It would be easy if you turned of that feature from your IDE / Editor.

@chaosprinz
Copy link
Contributor Author

Oh, yeah. Will look into it.

@chaosprinz
Copy link
Contributor Author

chaosprinz commented May 1, 2016

Was caused by the auto-fix of trailing Whitespace-"Feature" in Atom. Turned it of right now, copied back original files and reinserted my changes.
Sorry about that. Will have an eye on it in the future.

@octalmage
Copy link
Owner

No worries! Thanks a ton. This looks good.

@octalmage octalmage merged commit 73cc316 into octalmage:master May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants