Runtime: flush output buffer before accessing offset.#778
Closed
corwin-of-amber wants to merge 1 commit into
Closed
Runtime: flush output buffer before accessing offset.#778corwin-of-amber wants to merge 1 commit into
corwin-of-amber wants to merge 1 commit into
Conversation
hhugo
reviewed
Apr 25, 2019
| @@ -396,24 +396,30 @@ function caml_output_value (chanid,v,_flags) { | |||
| //Provides: caml_ml_seek_out | |||
| //Requires: caml_ml_channels | |||
Member
There was a problem hiding this comment.
Can you update the //Requires: bits ?
Contributor
Author
There was a problem hiding this comment.
Added them. Sorry. 🤕
Collaborator
|
@corwin-of-amber, do you have a repro of this bug that could be added as a test? I've recently expanded the capabilities of unit testing in the compiler and runtime, and this seems like a great scenario to see if I've covered some common use-cases. For examples, see the |
Member
|
I've tried to come up with a test without success #779 |
Contributor
Author
|
I've added the test in #777. |
Member
|
Thanks a lot. I've merged your fixes together with some tests. I'm closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simplest solution to #777 would be to flush the buffer first and ask questions later.
I suspect that any performance degradation resulting from this would be unnoticeable.