Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ack for 4.13 to 4.14 upgrades #190

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

sajauddin
Copy link
Collaborator

Adding code to add admin ack for 4.13 to 4.14 upgrades for both EUS as well as restricted upgrade

@ppc64le-cloud-bot ppc64le-cloud-bot added do-not-merge/non-mergeable size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2023
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
However, I think we should add this in terraform var.tfvars doc or give the user some kind of warning.

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sajauddin, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 4, 2023
@yussufsh
Copy link
Contributor

yussufsh commented Oct 4, 2023

@Rajalakshmi-Girish @mkumatag I see the bot is not removing the label [do-not-merge/non-mergeable] when lgtm is added. Seen this somewhere else as well. If I remove the label manually it gets merged. Kindly check.

@mkumatag
Copy link
Member

mkumatag commented Oct 4, 2023

@Rajalakshmi-Girish @mkumatag I see the bot is not removing the label [do-not-merge/non-mergeable] when lgtm is added. Seen this somewhere else as well. If I remove the label manually it gets merged. Kindly check.

this is because of the following reason, need to find why it is really blocked?

image

@mkumatag
Copy link
Member

mkumatag commented Oct 4, 2023

because commit is not signed!

@yussufsh
Copy link
Contributor

yussufsh commented Oct 4, 2023

because commit is not signed!

I see the DCO check as green 🤔

All commits are signed off!

@yussufsh
Copy link
Contributor

yussufsh commented Oct 4, 2023

I think the commits are signed but unverified. I have removed the strict branch rule. Thanks for letting me know @mkumatag .

@yussufsh yussufsh closed this Oct 4, 2023
@yussufsh yussufsh reopened this Oct 4, 2023
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit adb579e into ocp-power-automation:main Oct 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playbook run successfully but cluster is not upgraded to next required version.
4 participants