-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding ack for 4.13 to 4.14 upgrades #190
adding ack for 4.13 to 4.14 upgrades #190
Conversation
Signed-off-by: sajauddin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
However, I think we should add this in terraform var.tfvars doc or give the user some kind of warning.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sajauddin, yussufsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Rajalakshmi-Girish @mkumatag I see the bot is not removing the label |
this is because of the following reason, need to find why it is really blocked? |
because commit is not signed! |
I see the DCO check as green 🤔
|
I think the commits are signed but unverified. I have removed the strict branch rule. Thanks for letting me know @mkumatag . |
Adding code to add admin ack for 4.13 to 4.14 upgrades for both EUS as well as restricted upgrade