OpenGL: Fix using non-existing features on GLES 3.20 #8664
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* GL_PRIMITIVE_RESTART is not a valid enum for glEnable&co on GLES 3.20 * GL_CONTEXT_PROFILE_MASK is not a valid enum for glGetIntegerv on GLES 3.20 This ended up pushing GL_INVALID_ENUM to the stack when the aforementioned GL functions were called, and as these functions are not checked for errors, they would end up appearing later, possibly in user's code.
ocornut
pushed a commit
that referenced
this pull request
Jun 4, 2025
…ch would push a GL error. (#8664) * GL_PRIMITIVE_RESTART is not a valid enum for glEnable&co on GLES 3.20 * GL_CONTEXT_PROFILE_MASK is not a valid enum for glGetIntegerv on GLES 3.20
Owner
|
Thank you Dylam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up pushing GL_INVALID_ENUM to the stack when the aforementioned GL
functions were called, and as these functions are not checked for errors, they
would end up appearing later, possibly in user's code under unrelated GL functions.
(Ask me how I know they could appear in user's code 😅)
Note that I am going off the OpenGL ES 3.2 Reference Pages, which appears to be correct in this instance.