-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osx uses super+arrows for home/end, built on work in ocornut/imgui#473 #650
Conversation
3461fdb
to
921fc50
Compare
Updating this PR to keep current with master and also to better summarize the changes. Here's what this does:
This makes text cursor movement mostly idiomatic for OSX. Although text controls on OSX don’t usually map |
Thanks Michael, and sorry I haven't had time to look at it and merge. Will try soon. |
Hi Omar, thanks for your reply, don't sweat it! Happy to keep this merging cleanly until you have time to deal with Mac changes. |
Merged with a bunch of minor/shallow cleanups. Instructions in ShowUserGuide() and optionally one occurrence of calling ShowHelpMarker() in the demo code should also be updated to reflect OSX controls. |
Was really happy to see the OSX shortcuts implemented for text fields.
Last major thing missing for OSX text field conventions was to use
Cmd+Left/Right
forHome/End
andCmd+Up/Down
forCtrl+Home/End
.Added another bool,
ImGuiIO::HomeEndUsesArrowSuperKeys
. I don't know how many of these is too many, but trying to use the other var,ShortcutsUseSuperKey
, wasn't coming out as clear since it's not just a modifier swap.Also tested on Linux, didn't notice any regressions in the non-OSX behavior.