Backends: OSX, Metal: Support multi-contexts #5221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imgui.h
Outdated
| @@ -1953,7 +1954,7 @@ struct ImGuiIO | |||
|
|
|||
| // Optional: Notify OS Input Method Editor of the screen position of your cursor for text input position (e.g. when using Japanese/Chinese IME on Windows) | |||
| // (default to use native imm32 api on Windows) | |||
| void (*SetPlatformImeDataFn)(ImGuiViewport* viewport, ImGuiPlatformImeData* data); | |||
| std::function<void(ImGuiViewport* viewport, ImGuiPlatformImeData* data)> SetPlatformImeDataFn; | |||
There was a problem hiding this comment.
std::function is not necessary here and would be problematic for people using Dear ImGui from other languages. Your SetPlatformImeDataFn handler should not capture bd, it should use ImGui_ImplOSX_GetBackendData instead like all of the other backends.
(No comment on the rest of the PR, this just stood out to me while skimming.)
There was a problem hiding this comment.
OK.Thanks.I have modified the code.
ocornut
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure imgui_impl_metal.mm and imgui_impl_osx.mm for support Muti-contexts