-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImGuiKey Enum Missing Additional Keys for ABNT2 Keyboard Layout #8468
Comments
Thanks for your report. I would absolutely need the Scancode for those keys to use this information.
As specified in #7201 (comment) |
Could you also run with SDL3 and GLFW backend and print both scancode and keycodes for the 3 keys? |
I have pushed a9e5382 which sensibly rework a few things.
I would need more details from you on the ABNT keys. More references: |
Results:Win32OS: Windows
SDL2 / SDL3OS: Windows
¹ Keycodes macros goes up to Scan and Keycodes have the same value in SDL2/SDL3.
GLFWOS: Windows
Scancodes with the same values as in Win32.
|
… support. (#8468)
Thanks a lot for the details. What do you think? |
We may consider renaming These are the results after 557c77e:WindowsTableOS: Windows
Veredict: ✅ PASS SDL2 / SDL3TableOS: Windows
Veredict: ❌ FAIL GLFWTableOS: Windows
Veredict: ❌ FAIL Local ChangesMessed around to see what I would get, here are the results: WindowsNot changed. SDL2/ SDL3Using Keycode for the majority of them, just for example: Table 1OS: Windows
Table 2OS: Windows
Debug Log
Veredict: ✅ PASS GLFWBackend doesn’t differentiate between some keys... Veredict: ❌ FAIL |
I'm temporarily reverting the previous commit. The topic seem a little too complicated for me to handle now. (Your commit link: https://www.github.com/leonardovac/imgui/commit/81cd7e2bd81912e241f4220cff54550e7db79d60) Q: why/how do you need to use those keys within the context of Dear ImGui ? |
Version/Branch of Dear ImGui:
Commit 377a387, Branch: master
Back-ends:
imgui_impl_win32.cpp
Compiler, OS:
Windows 11 + MSVC 2022
Full config/build information:
No response
Details:
Our problem:
As mentioned in previous issues (#7136, #7201, #7306), the ImGuiKey enum is missing some keys present in non-US keyboard layouts. This issue is being opened primarily to add more data to the case, as well as reference the Dear ImGui keyboard layout mapping.
OS: Windows
Backend: Win32
Physical KB Layout: ABNT2
Input Layout: PT (Brazil ABNT2)
The following VK Codes: 0xC1, 0xC2, and 0xE2 aren't present in the ImGuiKey enum or ImGui_ImplWin32_KeyEventToImGuiKey. The first two codes don't appear on either the DE or FR keyboard layouts.
Keyboard example:
My POV:
I believe filling the gaps is more important than "fixing" the divergent keys, which can be quite challenging.
Extra
There's a typo at line 8770 of imgui.cpp:
Current:
// Those names a provided for debugging purpose and are not meant to be saved persistently not compared.
Intended?:
// These names are provided for debugging purposes and are not meant to be saved persistently or compared.
Screenshots/Video:
No response
Minimal, Complete and Verifiable Example code:
Use
ImGui::ShowDemoWindow()
or:With an ABNT2 keyboard.
The text was updated successfully, but these errors were encountered: