Initialize keyboard navigation with a highlighted, but inactive item #7237
Comments
|
Update: I managed to get the first part of the issue working with this adjustment: if ( ImGui::BeginChild( "Filters", ImVec2( 0.0f, ImGui::GetFrameHeight() ), ImGuiChildFlags_None, ImGuiWindowFlags_NavFlattened | windowNavFlags ) )
{
// ...
ImGui::SetNextItemWidth( -buttonWidth - ImGui::GetStyle().ItemSpacing.x );
ImGui::InputText( "##Pattern", pattern, 256 );
if ( setNavTarget )
{
// requesting a move to the right will deactivate the item without moving the highlight to the right,
// feels kinda dirty but works :)
ImGui::NavMoveRequestForward( ImGuiDir_Right, ImGuiDir_Right, ImGuiNavMoveFlags_None, ImGuiScrollFlags_None );
}
ImGui::SameLine();
ImGui::Button( "Clr" );
}
ImGui::EndChild();I can detect the second part of the issue (nav id references a child with flattened navigation) and reenable my custom navigation, but I still think it is worth a look. It doesn't feel right that the flattened child window is the current target and reports a visible highlight without having one. |
|
It would take a while to parse this issue and I only could skim through but I am not sure I understand what you aim or mean by "mixed" mode. You can leave nav system alone and query enter/escape keys fine? |
Your explanation and code seems very complicated and XY-problem-ey could you clarify exactly what you are trying to achieve in the first place? |
|
So, first about the why, the explanation of what I'm trying to achieve: I have a modal popup that is used to spawn assets. That fast way of using it is to open it with a keyboard shortcut, type a bit to filter from the available assets, select the desired one with arrow keys and then press enter to close the popup and place the asset (or escape to close and cancel). While the user is selecting the asset with up/down arrows in the asset list, the keyboard focus stays on the filter so that any typing can be used to further refine the filter directly. Pretty efficient usage. I can't use the default keyboard navigation for this, while selecting the items the filter would loose focus. Then again, I have advanced options next to the filter and potentially additional filters that I want to make accessible with keyboard navigation as well. Those are not accessible with the quick custom navigation, but the default keyboard navigation works pretty well for this, Therefore I made a "mixed mode", a way to toggle between different navigation modes. The alt key is certainly no industry standard for this, but it felt natural since it is used to trigger an alternate mode, that's what the key is usually meant for. Now the technical issues in short form:
|
…f Enter key as it doesn't go through Shortcut InputText: no need to call SetShortcutRouting() directly. Tangential to experiments for #7237
- It doesn't sense to test route without ownership (which may be overrided by code not using routing) - It also wouldn't be possible to call Shortcut() with _None anyway, since successful routing sets ownership. Tangential to experiments for #7237
|
I don't think your "technical issues 1 & 2" are things you should focus at the moment, below I'll give you pointers to concepts which should help solving this better. There might be remaining issues related to highlight we can discuss afterwards but I don't think it matter as much as you think it does.
I have among my upcoming task list to look into #2057 and #718 and provide better idioms on how to do that, TL;DR; there are many layers to it and its not simple to do ideally but I think you can approach already. I tried to implement something and found some issues specifically related to Enter key that I fixed now (2 commits linked above), Some key concepts:
In this attempt, notice how Shortcut() can be leveraged both to open the popup, handle up/down while stealing it away from navigation, and handle enter/escape in a way compatible with using the void testMixedNav2()
{
// Ctrl+M to re-open the modal popup, useful f.e. to temporarily close it and open the metrics window
//if (!ImGui::IsPopupOpen("MixedNav") && ImGui::IsKeyChordPressed(ImGuiKey_M | ImGuiMod_Ctrl))
if (ImGui::Shortcut(ImGuiKey_M | ImGuiMod_Ctrl, 0, ImGuiInputFlags_RouteGlobalLow))
ImGui::OpenPopup("MixedNav");
if (ImGui::BeginPopupModal("MixedNav"))
{
const bool focusFilter = ImGui::IsWindowAppearing();
// Programmatically decide of a condition to decide whether Enter to close will be enabled.
// May base it based on which child is focused?
bool disableEnterToClose = false;
if (ImGui::BeginChild("Filters", ImVec2(0.0f, ImGui::GetFrameHeight()), ImGuiChildFlags_None, ImGuiWindowFlags_NavFlattened))
{
const float buttonWidth = ImGui::CalcTextSize("Clr").x + ImGui::GetStyle().FramePadding.x * 2.0f;
if (focusFilter)
ImGui::SetKeyboardFocusHere();
static char pattern[256] = "*";
ImGui::SetNextItemWidth(-buttonWidth - ImGui::GetStyle().ItemSpacing.x);
ImGui::InputText("##Pattern", pattern, 256);
disableEnterToClose |= ImGui::IsItemFocused();
if (ImGui::IsItemActive())
{
if (ImGui::Shortcut(ImGuiKey_UpArrow))
printf("Up!\n"); // todo: update your selection data
if (ImGui::Shortcut(ImGuiKey_DownArrow))
printf("Down!\n"); // todo: update your selection data
}
ImGui::SameLine();
ImGui::Button("Clr");
}
ImGui::EndChild();
if (ImGui::BeginChild("Items", ImVec2(0.0f, -ImGui::GetFrameHeightWithSpacing())))
{
static bool selected[10] = {};
for (int i = 0; i < 10; ++i)
{
char name[32];
sprintf_s(name, "Item #%i", i);
ImGui::Selectable(name, &selected[i]);
}
}
ImGui::EndChild();
if (ImGui::Button("OK") || (!disableEnterToClose && ImGui::Shortcut(ImGuiKey_Enter)))
ImGui::CloseCurrentPopup();
ImGui::SameLine();
if (ImGui::Button("Cancel") || (ImGui::Shortcut(ImGuiKey_Escape)))
ImGui::CloseCurrentPopup();
ImGui::EndPopup();
}
}Try to toy with it and let me know. What remains IMHO:
|
|
About this part: // Programmatically decide of a condition to decide whether Enter to close will be enabled.
// May base it based on which child is focused?
bool disableEnterToClose = false;
[...]
ImGui::InputText("##Pattern", pattern, 256);
disableEnterToClose |= ImGui::IsItemFocused();
[...]
if (!disableEnterToClose && ImGui::Shortcut(ImGuiKey_Enter))
ImGui::CloseCurrentPopup();I added the filter specifically to allow pressing Enter to REACTIVATE the InputText() when focusing. |
|
Thank you. I will try out the I also took a look at
That would then reflect the actual visibility exactly and setting the value won't have to reconstruct the conditions for display based on other values. |
I will look into fixing it first. At that point I'm not even totally sure of the purpose of |
Fixed with 763100b |
Thank you. I have tried it in a test application and can confirm that flattened navigation now works as expected. |
|
I have added a few things related to those requests:
Technically I think the config options are sufficient for most people. Other tangentially related options:
Technically this # also pertain to use SetKeyboardFocusHere() and other functions which are still be redesigned/improved. ( Also note, if you have mods using internals, that those two fields have been renamed internally:
) |
Version/Branch of Dear ImGui:
Version 1.90.1 WIP (19002), Branch: docking
Back-ends:
imgui_impl_win32.cpp + imgui_impl_dx11/dx12.cpp
Compiler, OS:
Windows 10/11 + MSVC 2019/2022
Full config/build information:
Details:
I want to implement custom keyboard navigation for optimized workflow of the common use cases in a modal dialog, while still providing a fallback to default keyboard navigation for more complex usage without needing to touch the mouse. The custom navigation is no problem, but I can't seem to get the switch to the default navigation just right. The example code has a modal popup with basically no functionality, it is stripped down to just demonstrate the issue.
When I press and release the left Alt key, I want to switch to the default keyboard navigation. I want the filter input to be visibly highlighted, but not active, so that I could f.e. navigate to the button right of it by pressing right. That almost works (with setting a few internals), except for the deactivation of the widget. If I clear the active ID, the text input stays active, same if I defer that clear to the next frame. And because of being active, the text input consumes both left and right arrow keys. Calling
NavMoveRequestCancel()will deactivate the item, but gets rid of the highlight as well, which is also undesirable. I also tried setting the nav item, window and so on directly to the state that the metrics window shows, but without success. I also added Escape key down and up events to the input queue to emulate an initial "manual" deactivation, didn't help either. Is there a way I could fiddle with the internals to achieve what I want?There is also a related issue reproducible with the example code, one that I think is an actual bug:
When hitting Escape after pressing Alt, the items gets deactivated (the state I want after pressing Alt). When hitting Escape again, the navigation moves up a level to the child window. In a non-flattened window, the entire child window would then be highlighted, as is the case when navigating into the item list and back out again. Hitting Escape again would then disable the highlight display, triggering my return to custom navigation. But the "Filters" child window has flattened navigation. When hitting Escape, the highlight should be moved further up and therefore properly deactivated, but it won't be. Instead, it stands invisibly on the child window with flattened navigation while being marked as visible (
GetIO().NavVisibleis true), as can be seen in the metrics window.Screenshots/Video:
No response
Minimal, Complete and Verifiable Example code:
The text was updated successfully, but these errors were encountered: