imgui_impl_opengl3 macro redefinitions using GLAD, GLFW, OPENGL

[petrasvestartas]

Hi,

I have a lot of macros redefined mainly coming from #include "imgui_impl_opengl3.h" and "imgui_impl_opengl3.cpp"
I am using GLAD, GLFW, OPENGL, and recent IMGUI. How can I avoid these redefinitions?

After including this #define IMGUI_IMPL_OPENGL_LOADER_CUSTOM
I get 4 unsafe warnings, maybe I am to picky but I would like to resolve those:

[PathogenDavid]

For future reference, build issues should be opened as GitHub Discussions.

imgui_impl_opengl3.cpp

Generally speaking, you should not include .cpp files. They should be built separately and then linked, which avoids this issue.

As you've found though, if you're doing a unity build you can define IMGUI_IMPL_OPENGL_LOADER_CUSTOM to avoid the duplicate definitions.

I get 4 unsafe warnings, maybe I am to picky but I would like to resolve those:

Not sure why you're getting those warnings unless you modified imgui_impl_opengl3.cpp, it's supposed to disable them:

imgui/backends/imgui_impl_opengl3.cpp

Lines 88 to 90 in edcd5b1

	#if defined(_MSC_VER) && !defined(_CRT_SECURE_NO_WARNINGS)
	#define _CRT_SECURE_NO_WARNINGS
	#endif

The "secure" variants of those functions are Microsoft-specific. Dear ImGui is cross-platform so we can't use them.

[ocornut]

If the standard headers are included before the define you’d get the warning, therefore it makes sense they would get the warnings on a unity/jumbo build.

[PathogenDavid]

Oh right, that'd do it too 😅

[ocornut]

I have added extra comments in the header of this file, hoping it'd help people find the issue.