Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docking doesn't work over child window when parent is docked #3420

Closed
coolxv opened this issue Aug 20, 2020 · 4 comments
Closed

Docking doesn't work over child window when parent is docked #3420

coolxv opened this issue Aug 20, 2020 · 4 comments
Labels
bug docking

Comments

@coolxv
Copy link

coolxv commented Aug 20, 2020

Version/Branch of Dear ImGui:

Version: 1.78 WIP
Branch: table + docking

Back-end/Renderer/Compiler/OS

Back-ends: imgui_impl_win32.cpp + imgui_impl_dx11.cpp

Operating System: Windows

My Issue/Question:

1597913259674
@ocornut ocornut changed the title Docking doesn't work well with scrolling. Docking doesn't work over child window Aug 20, 2020
@malamanteau
Copy link

I just noticed this issue as well, it was not present in a previous version I was using which was somewhere around 1.74.

@ocornut ocornut changed the title Docking doesn't work over child window Docking doesn't work over child window when parent is docked Aug 20, 2020
@ocornut
Copy link
Owner

ocornut commented Aug 20, 2020

Working on it currently.

@ocornut ocornut added the bug label Aug 20, 2020
@ocornut
Copy link
Owner

ocornut commented Aug 21, 2020

Broken by 85a661d

ocornut added a commit that referenced this issue Aug 21, 2020
@ocornut
Docking: Fixed docking while hovering a child window. (#3420) broken by
cf31254 
85a661d. Improve metrics debugging.
@ocornut
Copy link
Owner

ocornut commented Aug 21, 2020

Should be fixed by cf31254
Also made sure things works with floating dockspace. We will be adding regression tests soon.
Untitled

@ocornut ocornut closed this as completed Aug 21, 2020
ocornut added a commit that referenced this issue Aug 25, 2020
@ocornut
Docking: Fix honoring payload filter with overlapping nodes. (we inco…
30f0900 
…rrectly over-relied on g.HoveredDockNode when making change for #3398)

Essentially undo part of 85a661d (#3398) + ref cf31254 (#3420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug docking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@malamanteau @ocornut @coolxv