-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle Button? #1537
Comments
Hello, From a design point of view the only barrier to integration in master is deciding how does it fit within the styling system: do we expose new enum colors? And as there's no concept of a preferred language in core imgui it's simpler to not include on/off text. If you implement one locally you can answer those questions more easily. |
Okay i will try my best. Can i somewhere find examples of custom controls / widgets to get an idea how to build it? |
Not sure I'm answering the question, but the code below works well for me (the trick is ImGui::IsItemClicked() ):
( some code ... )
|
Searching for something like this: |
EDIT typos. If you are just starting with imgui I'd suggest not going against the current, use Checkbox for now and by the time you decide if imgui is right now you'll find it easy to create your own variation of it. You can use InvisibleButtion() to detect click and/or hovering + ImDrawList API to draw whatever you need need. If you include In the code @ebachard posted "the trick is ImGui::IsItemClicked()" is because he cares about toggling the boolean on the mouse PRESS event rather than the release event. This is the sort of finer detail you can access with I'll post some pseudo code soon. |
Here's a simple proof of concept:
There are lots of subtleties that makes it more work to provide a default one:
|
Wow cool! I have one more question: What is the str_id? At my side its not toggling lets say. I think its because of this id. As i said im really an beginner in this topic :/ |
Please read the FAQ about identifiers, also make sure you understand how imgui lets you manage your state (the boolean has to be persistent on your side). ID: For interaction that cannot be fully processed in one frame, during ImGui needs to identify widgets somehow. It uses an ID stack and typically at the top of the ID stack we use the label widget. Here this widget doesn't display anything but to use Note that we only need this identifier because the standard way to process mouse UI clicks is to require both the mouse click and the mouse release to be hovering the widget. Those events don't happen at the same time and we need to identify the button to compare if the mouse click happened over the same object at the mouse release. If we are happy with triggering the toggle on mouse click only, that can be processed immediately and not require an identifier at all. In the code above you could entirely remove str_id, pass a dummy string to InvisibleButton() and then instead of reading the return value of InvisibleButtion(), instead use the return value of IsItemClicked(). Below: This variation also animate the toggle position and background color, but it is using the internal API and a new field I have just added to track the activation time.
|
Thanks a lot for the new example, and thanks a lot for your explanations. I'm glad to learn such lessons, about being extremely precise with controls, and I'll keep the issue in my list. |
…ll come up with a better design later. This reverts commit 007f403.
hey, is there any toggle button snippet around that uses the same normal style that a button? (square box with text label and global styles) |
sorry, this above snippet seems to look fine to me. |
What's the progress on this one? @ocornut |
Is this planned for eventual inclusion? |
how can i make the border smoother? it's a bit "rough" and i want to try to make it look better. |
@XanaxOG , you can draw a colored border to a widget like this: ImVec4 colorBorder{ 1,1,1,0.5 };
float lineWidth = 2.0;
ImGui::PushStyleColor(ImGuiCol_Border, colorBorder);
ImGui::PushStyleVar(ImGuiStyleVar_FrameBorderSize, lineWidth);
// draw button
ImGui::PopStyleColor();
ImGui::PopStyleVar(1); |
It doesn't really work still seems kinda rough, especially the button border |
I added some code minimization and the colors of the toggle are the same as the theme's colors: void ToggleButton(const char* str_id, bool* v)
{
ImVec4* colors = ImGui::GetStyle().Colors;
ImVec2 p = ImGui::GetCursorScreenPos();
ImDrawList* draw_list = ImGui::GetWindowDrawList();
float height = ImGui::GetFrameHeight();
float width = height * 1.55f;
float radius = height * 0.50f;
ImGui::InvisibleButton(str_id, ImVec2(width, height));
if (ImGui::IsItemClicked()) *v = !*v;
ImGuiContext& gg = *GImGui;
float ANIM_SPEED = 0.085f;
if (gg.LastActiveId == gg.CurrentWindow->GetID(str_id))// && g.LastActiveIdTimer < ANIM_SPEED)
float t_anim = ImSaturate(gg.LastActiveIdTimer / ANIM_SPEED);
if (ImGui::IsItemHovered())
draw_list->AddRectFilled(p, ImVec2(p.x + width, p.y + height), ImGui::GetColorU32(*v ? colors[ImGuiCol_ButtonActive] : ImVec4(0.78f, 0.78f, 0.78f, 1.0f)), height * 0.5f);
else
draw_list->AddRectFilled(p, ImVec2(p.x + width, p.y + height), ImGui::GetColorU32(*v ? colors[ImGuiCol_Button] : ImVec4(0.85f, 0.85f, 0.85f, 1.0f)), height * 0.50f);
draw_list->AddCircleFilled(ImVec2(p.x + radius + (*v ? 1 : 0) * (width - radius * 2.0f), p.y + radius), radius - 1.5f, IM_COL32(255, 255, 255, 255));
} |
I feel that this circle is a bit aliased, even when anti-aliasing has been enabled on in the imgui::style. Does anyone know of a good solution to make the round edge not that jaggle? |
@pinojojo , did you tried to change the circle segments resolution? |
EDIT: I ended up finally figuring it out. For anyone who wants the non circle version: (I used nerdtronik's comment as a base for this and only changed it enough to not use a circle for the knob in the slider) obligatory image showcasing the edit in action inline void ToggleButton(const char* str_id, bool* v)
{
ImVec4* colors = ImGui::GetStyle().Colors;
ImVec2 p = ImGui::GetCursorScreenPos();
ImDrawList* draw_list = ImGui::GetWindowDrawList();
float height = ImGui::GetFrameHeight();
float width = height * 1.55f;
float radius = height * 0.50f;
float rounding = 0.2f;
ImGui::InvisibleButton(str_id, ImVec2(width, height));
if (ImGui::IsItemClicked()) *v = !*v;
ImGuiContext& gg = *GImGui;
float ANIM_SPEED = 0.085f;
if (gg.LastActiveId == gg.CurrentWindow->GetID(str_id))// && g.LastActiveIdTimer < ANIM_SPEED)
float t_anim = ImSaturate(gg.LastActiveIdTimer / ANIM_SPEED);
if (ImGui::IsItemHovered())
draw_list->AddRectFilled(p, ImVec2(p.x + width, p.y + height), ImGui::GetColorU32(*v ? colors[ImGuiCol_ButtonActive] : ImVec4(0.78f, 0.78f, 0.78f, 1.0f)), height * rounding);
else
draw_list->AddRectFilled(p, ImVec2(p.x + width, p.y + height), ImGui::GetColorU32(*v ? colors[ImGuiCol_Button] : ImVec4(0.85f, 0.85f, 0.85f, 1.0f)), height * rounding);
ImVec2 center = ImVec2(radius + (*v ? 1 : 0) * (width - radius * 2.0f), radius);
draw_list->AddRectFilled(ImVec2((p.x + center.x) - 9.0f, p.y + 1.5f),
ImVec2((p.x + (width / 2) + center.x) - 9.0f, p.y + height - 1.5f), IM_COL32(255, 255, 255, 255), height * rounding);
} 0.5f rounding doesn't give a perfect circle at the moment but I'm sure that should be easy to fix EDIT 2: it appears that the animation might be broken as well strangely? I didn't really touch anything related to animation so I'm not sure what's going on there |
Hello all, I took some inspiration from this thread and from the way First, I come bearing gifs: And here's the repo if you're looking to dive in: cmdwtf/imgui_toggle After taking a look at what you'd all done in this thread, put together a small API that I felt came across in the most Dear ImGui way. It also implemented a majority of the features you all showed off here: Theme (and override) colors, rounding vs square toggles, animations, and label-less toggles. I went a bit further by also making the squircling (both for the knob and frame) adjustable. In addition, since I was drawing inspiration from the Currently the major shortcomings are those discussed about the dependency on I've added some advanced configuration to expose a lot of behavior and styling options; gif is updated! Feedback is always appreciated, and I hope you're able to make use of it in your projects! |
Cool! Thank you, this definitely will be helpful! |
Also here another way with the ImGui::Button
|
Hey there,
did ImGui provide a ToggleButton? Haven't found anything related to this. If i haven't saw it sorry
Kind Regards
Daniel
The text was updated successfully, but these errors were encountered: