Add LICENSE file to wheels#69
Merged
ddelange merged 2 commits intooconnor663:masterfrom May 19, 2025
Merged
Conversation
Add a project section with the minimum required name and version fields. This allows maturin to add the license file into the wheel. Signed-off-by: Julien Stephan <jstephan@baylibre.com>
ddelange
reviewed
May 19, 2025
Collaborator
Contributor
Author
|
excellent thank you! |
This was referenced Oct 11, 2025
messense
pushed a commit
to PyO3/maturin
that referenced
this pull request
Oct 14, 2025
> I didn't understand why maturin [fails](https://github.com/oconnor663/blake3-py/actions/runs/18435038379/job/52527366829#step:10:66) if I try to make name dynamic too. docs for one of the issues I mentioned in #2769 > Also License will be missing from the wheel even if [project] is not defined at all, which is also undocumented, see oconnor663/blake3-py#69. this one looks like an actual bug in maturin to me, but I might be mistaken.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wheels distributed on pypi don't include the License.
Add a project section with the minimum required name and version fields. This allows maturin to add the license file into the wheel.