feat(TranslateService): pass 'interpolateParams' to MissingTranslationHandler in addition to 'key' #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets consumers do more with missing translations.
Notably, you could implement
defaultValue
behavior similar to how you would use i18next in Angular 1, which could Close #160@ocombe I was having issues running the test suite locally, so I'm not certain if the test case I added works.
Also, an obvious extension of this PR (if you like it) would be to modify the default
handle()
method to behave as I've shown above sodefaultValue
works for everyone