feat(MissingTranslationHandler): pass additional paramaters to handle
#230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pass `key`, `translateService`, and `interpolateParams` (if provided) to the `handle` method of `MissingTranslationHandler` for advanced scenarios.
|
Wow it looks nice, you even added the tests ! Thanks, I'll try to take a look at it soon (but really busy until next week) |
fix(TranslateModule): use exported factory function to enable AOT compiling
fix(TranslateService): update cross browser support for getBrowserLang
Changed the peerDependencies, it will no longer support beta
|
Sorry, I didn't forget you, I just haven't had much time, I'll check this tomorrow. Could you fix the conflicts in the mean time ? |
Allows to avoid this case (used in the [plunker](http://plnkr.co/edit/btpW3l0jr5beJVjohy1Q?p=preview)): `translate.addLangs(["en", "fr"]); translate.setDefaultLang('en'); let browserLang = translate.getBrowserLang(); translate.use(browserLang.match(/en|fr/) ? browserLang : 'en');`
Add code snippet to use in case of AoT compiling (especially on Ionic 2 from RC 0) See #218
|
new plans to merge this? |
* pass `key`, `translateService`, and `interpolateParams` (if provided) to the `handle` method of `MissingTranslationHandler` for advanced scenarios.
|
Fixed conflicts by rebasing onto the latest master, opened #275, closing current PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key,translateService, andinterpolateParams(if provided) to thehandlemethod ofMissingTranslationHandlerfor advanced scenarios.MissingTranslationHandlerREADME adjustments based on new function interfaceObsoletes #214 .
Closes #160, #221