fix: @oclif/errors should be a direct dependency #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `@oclif/errors` is required from `index.ts` (see below), it should be modeled as a direct `dependency` and not as a `devDependency`. In the current state of things, it is not possible to use this library with `yarn` 2, as this produces the following error: ``` Error: @oclif/plugin-help tried to access @oclif/errors, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound. Required package: @oclif/errors (via "@oclif/errors") Required by: @oclif/plugin-help@npm:3.2.0 (via <redacted>/.yarn/cache/@oclif-plugin-help-npm-3.2.0-94fac21a1a-d42ba4b5f0.zip/node_modules/@oclif/plugin-help/lib/) ``` https://github.com/oclif/plugin-help/blob/9c7b287980ea4fb3a42eea9f9aa3c2d31d25e309/src/index.ts#L2
|
Thanks for the contribution! Before we can merge this, we need @RomainMuller to sign the Salesforce.com Contributor License Agreement. |
|
Asked my employer for review of the CLA and hopefully permission to sign. Will update when I hear back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
@oclif/errorsis required fromindex.ts(see below), it should be modeled as a directdependencyand not as adevDependency. In the current state of things, it is not possible to use this library withyarn2, as this produces the following error:plugin-help/src/index.ts
Line 2 in 9c7b287