Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

oclif-dev publish missing aws-sdk #42

Closed
krohrsb opened this issue Jun 16, 2018 · 2 comments
Closed

oclif-dev publish missing aws-sdk #42

krohrsb opened this issue Jun 16, 2018 · 2 comments

Comments

@krohrsb
Copy link

krohrsb commented Jun 16, 2018

When a CLI depends on dev-cli, and attempts to run oclif-dev publish, the following occurs:

oclif-dev: uploading targets
oclif-dev: s3:uploadFile ./dist/my-cli-v0.11.10/my-cli-v0.11.10-darwin-x64.tar.gz s3://my-cli-testing/my-cli-v0.11.10/my-cli-v0.11.10-darwin-x64.tar.gz
Error: Cannot find module 'aws-sdk/clients/s3'
    at Object.get s3 [as s3] (~/dev/my-cli/node_modules/@oclif/dev-cli/lib/aws.js:20:51)
    at Promise (~/dev/my-cli/node_modules/@oclif/dev-cli/lib/aws.js:42:21)
    at new Promise (<anonymous>)
    at Object.uploadFile (~/dev/my-cli/node_modules/@oclif/dev-cli/lib/aws.js:39:45)
    at releaseTarballs (~/dev/my-cli/node_modules/@oclif/dev-cli/lib/commands/publish/index.js:28:40)
    at uploadTarball (~/dev/my-cli/node_modules/@oclif/dev-cli/lib/commands/publish/index.js:31:19)
error Command failed with exit code 1.

Looks like this is a devDep within dev-cli which would mean it is not installed when consuming cli's depend on it, I believe.

https://github.com/oclif/dev-cli/blob/master/package.json#L38

@jdx
Copy link
Contributor

jdx commented Jun 16, 2018

You need to install aws-sdk separately. I'll put this in the help for oclif-dev pack.

jdx added a commit that referenced this issue Jun 16, 2018
@jdx jdx closed this as completed in 3694551 Jun 16, 2018
@krohrsb
Copy link
Author

krohrsb commented Jun 16, 2018

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants