Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

fix(hooks): match type of Config.runHook to IConfig.runHook #158

Closed
wants to merge 1 commit into from

Conversation

jgwhite
Copy link

@jgwhite jgwhite commented Aug 3, 2020

This mismatch was proving tricky to work around over in oclif/dev-cli#141

I’d like to do a little more testing against the other packages that depend upon this before I mark it as ready-for-review.

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #158   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           2       2           
  Lines          12      12           
  Branches        3       3           
======================================
  Misses         12      12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11c865...5adbc55. Read the comment docs.

@jgwhite
Copy link
Author

jgwhite commented Aug 3, 2020

@RasPhilCo do you recall the reason for #58 ?

@RasPhilCo
Copy link
Contributor

I believe so folks can define hooks outside the ones typed.

@jgwhite
Copy link
Author

jgwhite commented Aug 4, 2020

Ah, OK. So maybe we should loosen the type for IConfig.runHook?

@jgwhite
Copy link
Author

jgwhite commented Aug 4, 2020

It looks like the narrower type does work for custom hooks (the type of opts expands to simply object)…

image

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants