This repository has been archived by the owner on Aug 22, 2023. It is now read-only.
feat: use esModuleInterop when defined (fixes #179) #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @mfellner to sign the Salesforce.com Contributor License Agreement. |
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 68.69% 69.62% +0.93%
==========================================
Files 7 7
Lines 428 428
Branches 116 116
==========================================
+ Hits 294 298 +4
+ Misses 84 83 -1
+ Partials 50 47 -3
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
martijnwalraven
added a commit
to apollographql/apollo-tooling
that referenced
this pull request
Mar 20, 2019
See oclif/config#61 Unfortunately, this fix doesn't interpret `extends` in `tsconfig.json`, so I had to add an explicit `"esModuleInterop": true`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes oclif/oclif#179.
esModuleInteroptoTSConfig.ts-node.test.tsThis pull request updates
ts-node.tsto use theesModuleInteropof loadedtsconfig.jsonfiles. It should now be possible to write oclif-based CLIs in TypeScript projects withesModuleInteropset to true.