This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Update copyright and warranty commands to typescript #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
force-pushed
the
680-convert_info_cmd_ts
branch
from
12891b1
to
e787e51
Compare
|
esModuleInterop fixed by oclif/config#61 |
ishantiw
reviewed
Dec 14, 2018
src/commands/node/forging.ts
Outdated
| status: string, | ||
| publicKey: string, | ||
| password?: string, | ||
| ) => { |
src/commands/transaction/create.ts
Outdated
| const resolveFlags = ( | ||
| accumulated: ReadonlyArray<string>, | ||
| [key, value]: [string, string | boolean | undefined], | ||
| ) => { |
mitsuaki-u
reviewed
Dec 14, 2018
| "globby": "8.0.1", | ||
| "husky": "0.14.3", | ||
| "lint-staged": "5.0.0", | ||
| "mocha": "4.0.1", | ||
| "nyc": "11.3.0", | ||
| "prettier": "1.9.2", | ||
| "rxjs-compat": "6.3.3", |
There was a problem hiding this comment.
This is for husky, without this it seems like it's not working.
I have no idea why it doesn't work though...
mitsuaki-u
approved these changes
Dec 14, 2018
shuse2
changed the base branch from
662-update_transaction_cmd_ts
to
649-convert_to_typescript
ishantiw
approved these changes
Dec 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating copyright and warranty commands to TypeScript.
Review checklist